general comment, validate_mode = 'autofix' seems more likely to produce invalid output and/or result in a collection getting skipped than otherwise. to me its biggest value is typecasting stuff like id=1 to id="1" etc. not sure how much value there is in making it explicit, maybe we just have warn true/false and otherwise handle things silently?

hmm, if they do something like g.plot(validate_mode='autofix'), what do we want to happen , or not happen, w/ collections?

that was mostly added b/c people keep having dirty data that fails arrow conversion and rather seeing it load vs fixing their data/cfg

@lmeyerov regarding general comment above: im thinking maybe instead of validate we call it strict with "true" or "false" where strict true will throw errors and false will pass over non-compliant collections

autofix sorta implies to me that we are "correcting" the data when invalid but we arent really i think? more just passing it over if there are any mistakes

if we feel we need to type cast we might want to just do it anyway strict true or not

the issue with strict true/false is that's closer to what we had before, and users were complaining that they just wanted it to 'work', hence autofix (coerce++). validate=true/false is closer to what you're thinking, while 'autofix' (coerce) is "it'll run, but may not be what you want, but you said wanted soemthing that runs"

We therefore have leeway in what autofix does --- we just need to warn (if warn=auto/true), and do what. So the q is... what should it do wrt diff collections errors, if strong opinions about any params in any direction?

My default intuition is probably:

• drop collections with invalid gfql
• colors: random-but-deterministic? or neutral grey / transparent? (default black looks buggy)
• others: ??? disable / see if there's default values ?

agree with that, i think we do the 3 bullets listed if strict (or whatever we want to call it) is false and its almost what we are doing right now. theres only 1 point i would make about the current implementation

• instead of just trying to typecast stuff (which a lot of the time doesnt work), i would prefer we do default values or in the case of colours, random colours

in summary its only the approach i think might need to change, not the intention

EDIT: if we do the above it actually gets closer to a true autofix than what it was before, so i dont have an issue with the name anymore

Review Comments Addressed (commits 23d1f00, d2bdf02, 47d87e8)

HIGH Priority - Fixed

MEDIUM Priority - Fixed

LOW Priority - Fixed

Still Open / Deferred

Key Design Decisions

1. No ID auto-generation: Server requires IDs but client should not generate arbitrary ones like set_0. Collections without IDs are dropped in autofix mode with a warning. Users must provide meaningful IDs.

2. Precise exception handling: Changed except Exception to except (TypeError, ValueError, GFQLValidationError) to avoid masking bugs.

3. Cross-validation for intersections: New _validate_intersection_references() ensures intersection sets reference actual collection IDs. Dangling references are caught before hitting the backend.

4. GFQL parsing consolidation: _normalize_gfql_ops now delegates to _wrap_gfql_expr from collections.py as the canonical implementation.

5. Proper type handling: Used dict(entry) to convert TypedDicts to plain dicts at runtime for uniform handling, avoiding unchecked static casts.

CI Status: All jobs green (manual workflow_dispatch run 21793451172) - python-lint-types 3.8-3.14 ✅, all test suites ✅

Thanks for the thorough reviews! All comments have been addressed:

Consolidation & Architecture:

• Moved GFQL normalization to compute/ast.py:normalize_gfql_to_wire() as canonical implementation
• Clean import graph: models → compute → helpers/validation
• collections.py and validate_collections.py both call compute/ast

Validation Improvements:

• Intersection DAG validation: supports intersections-of-intersections, detects self-references and cycles
• Added AssertionError to exception handling (AST from_json methods use bare asserts)
• Empty sets list validation
• Cross-validation of intersection set ID references
• Auto-generate kebab-case IDs in autofix mode (set-0, intersection-1)

Code Quality:

• Removed dead code after return statements
• Proper type handling with dict(entry) instead of unchecked casts
• 22 tests covering all validation paths

CI is green, ready for merge.